-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aspnet5] Rename/deprecate aspnet5 for newer terminology #3085
Comments
@jimschubert thanks for the details. Do you think there's by any chance they will switch to a different (maybe better) name later? I suggest we wait and see as IMO renaming the generator is not something with the highest priority. |
@wing328 It's possible they'll change it. I feel like the Microsoft community sometimes does things to appear edgy or cool. For all we know, they could rage-quit open source .NET ;D But seriously, they're pushing for a June 27 1.0 release. (source). I doubt they'll change it this close to version 1.0 release. edit: Also Scott's blog post was from January. |
@wing328 is this closed as won't fix? |
(reopened the issue) I suggest we keep it as it's for now. If we get more feedback from developers about renaming the generator to something, then we'll revisit this again. |
@wing328 Now that we have If so, I could remove it in the 2.3.0 branch to get this issue closed out. |
@jimschubert yes please. |
last item on this PR is to fully remove the aspnet5 generator. I'd recommend doing this after the 2.3.0 release, but I wouldn't be sad if it happened beforehand. @wing328 thoughts? |
@wing328 I went ahead and opened the PR against 2.3.0. Feel free to cherry-pick into master if needed. That PR should allow this issue to close. |
Description
Per Scott Hanselman's blog post, the server technology's name is no longer called ASP.NET 5 and is now called ASP.NET Core 1.0.
Rather than rename to aspnetcore or some variant, it would probably be best to create an
aspnet
server generator with library options for different versions (4.x, Core 1.0, Web Forms, etc.).Swagger-codegen version
2.1.6
Swagger declaration file content or url
AspNet5ServerCodegen.java
Command line used for generation
N/A
Steps to reproduce
List languages, notice
aspnet5
:swagger-codegen langs | tr -s " " "\n" | grep asp
Related issues
N/A
Suggest a Fix
Not sure how to 'deprecate' a language in favor of another. Maybe:
AspNet5ServerCodegen
toAspNetCoreCodegen
AspNetServerCodegen
toaspnet
AspNet5ServerCodegen
and extend fromAspNetServerCodegen
aspnet5
AspNetServerCodegen
toMETA-INF\services
definitionAspNetServerCodegen
, or otherwise indicate deprecationThe text was updated successfully, but these errors were encountered: