Missing array type when using @ArraySchema

[paulrutter]

Since we upgraded from 2.2.11 to 2.2.21, the output when using @ArraySchema is no longer correct.
We're outputting 3.1 via openAPI31: true.

The output in JSON misses "type": "array".
See example on https://github.com/swagger-api/swagger-core/wiki/Swagger-2.X---Annotations#arrayschema

Relevant annotations used:

content = @Content(
        mediaType = APPLICATION_JSON,
        array = @ArraySchema(schema =  @Schema(implementation = BulkResultBean.class)),
        examples = {
                @ExampleObject(
                    name = "Example bulk response",
                    description = "Example bulk response",
                    value = "description...."
                )
       }
})

Left is with 2.2.11, right with 2.2.21.

I see several mentions of fixes in array schema in the changelog, but i doubt this output is now correct.

[micryc]

Hi @paulrutter Are you still experiencing this issue ? I tried to reproduce with core 2.2.22 version and it looks like type shows up in specification. For now I am gonna close this ticket, if issue still appears for you, feel free to reopen

            "content" : {
              "application/json" : {
                "schema" : {
                  "type" : "array",
                  "items" : {
                    "$ref" : "#/components/schemas/BulkResulBean"
                  }
                },
                "examples" : {
                  "Example bulk response" : {
                    "description" : "Example bulk response",
                    "value" : "description...."
                  }
                }
              }
            }
          

[paulrutter]

I will check it out @micryc and reopen if needed.

[taylortails]

I'm seeing this behaviour with 2.2.22 here:
springdoc/springdoc-openapi-demos#68

It's not clear to me yet whether it's a spring or swagger issue

[taylortails]

This looks to be the cause because a JsonSchema is created without a type:

https://github.com/swagger-api/swagger-core/blob/master/modules/swagger-core/src/main/java/io/swagger/v3/core/util/AnnotationsUtils.java#L510

[paulrutter]

@micryc we should reopen, as it apperantly is not fixed (in all cases at least)

[owen4gh]

Changing line 510 in modles/swagger-core/src/main/java/io/swagger/v3/core/util/AnnotationsUtils.java from

arraySchemaObject = new JsonSchema();

to

arraySchemaObject = new ArraySchema();

appears to fix the issue.

[paulrutter]

Can you create a pr for it @owen4gh?

[owen4gh]

Created #4700

[micryc]

@owen4gh @paulrutter Thank you a lot for reporting this bug and provided fixes, changes merged and I am closing the issue.

[paulrutter]

@micryc When will this be part of a release?

[micryc]

Hi @paulrutter this fix is a part of the newest Core 2.2.23 release

[paulrutter]

@micryc i don't see it on https://mvnrepository.com/artifact/io.swagger.core.v3/swagger-core yet, is it behind?

[micryc]

@paulrutter Maven repository is usually delayed, check it here: https://central.sonatype.com/artifact/io.swagger.core.v3/swagger-core