refactor: consolidate export of getConfigsWithDefaultFallback (#476)

Author: tim-lai

src/plugins/topbar/actions/convert-oas2-to-oas3/index.js

@@ -1,6 +1,6 @@
 import { postPerformOasConversion } from '../../utils.js';
 import { getSpecVersion } from '../../../../utils/spec-get-spec-version.js';
-import { getConfigsWithDefaultFallback } from './utils.js';
+import { getConfigsWithDefaultFallback } from '../utils.js';
 
 export const convertDefinitionToOas3 = () => async (system) => {
   const { specSelectors, specActions } = system;

src/plugins/topbar/actions/generator/index.js

@@ -2,8 +2,8 @@
 import { getGenerator2Definition } from '../../utils.js';
 import { getFileDownload } from '../../../../utils/common-file-download.js';
 import { getSpecVersion } from '../../../../utils/spec-get-spec-version.js';
+import { getConfigsWithDefaultFallback } from '../utils.js';
 import {
-  getConfigsWithDefaultFallback,
   getSpecVersionString,
   validateHttpGeneratorsExists,
   fetchOasGeneratorLists,

src/plugins/topbar/actions/generator/utils.js

@@ -1,22 +1,8 @@
 /* eslint-disable camelcase */
 import { getGeneratorsList, postGenerator3WithSpec } from '../../utils.js';
+import { getConfigsWithDefaultFallback } from '../utils.js';
 import { defaultFixtures } from '../topbar-actions-fixtures.js';
 
-// currently re-used
-export const getConfigsWithDefaultFallback = (system) => {
-  let { swagger2GeneratorUrl, oas3GeneratorUrl, swagger2ConverterUrl } = system.getConfigs();
-  if (!swagger2GeneratorUrl) {
-    swagger2GeneratorUrl = defaultFixtures.swagger2GeneratorUrl;
-  }
-  if (!oas3GeneratorUrl) {
-    oas3GeneratorUrl = defaultFixtures.oas3GeneratorUrl;
-  }
-  if (!swagger2ConverterUrl) {
-    swagger2ConverterUrl = defaultFixtures.swagger2ConverterUrl;
-  }
-  return { swagger2GeneratorUrl, oas3GeneratorUrl, swagger2ConverterUrl };
-};
-
 export const getSpecVersionString = ({ isOAS3, isSwagger2, isOAS3_1, isAsyncApi2 }) => {
   // extendable to use additional string constants
   const specStringConstants = {

src/plugins/topbar/actions/convert-oas2-to-oas3/utils.js renamed to src/plugins/topbar/actions/utils.js

@@ -1,6 +1,5 @@
-import { defaultFixtures } from '../topbar-actions-fixtures.js';
+import { defaultFixtures } from './topbar-actions-fixtures.js';
 
-// currently re-used
 export const getConfigsWithDefaultFallback = (system) => {
   let { swagger2GeneratorUrl, oas3GeneratorUrl, swagger2ConverterUrl } = system.getConfigs();
   if (!swagger2GeneratorUrl) {