Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discriminator support for allOf #469

Closed
fehguy opened this issue Jun 5, 2015 · 9 comments
Closed

Add discriminator support for allOf #469

fehguy opened this issue Jun 5, 2015 · 9 comments

Comments

@fehguy
Copy link
Contributor

fehguy commented Jun 5, 2015

We now have composition support but the discriminator is not identified well enough for rendering in the UI.

@fehguy fehguy added the P2 label Jun 5, 2015
@webron webron changed the title Add descriminator support for allOf Add discriminator support for allOf Jun 5, 2015
@datoulei
Copy link

datoulei commented Jun 7, 2015

can you show me the example? i try many times but it can't work

@webron
Copy link
Contributor

webron commented Jun 8, 2015

@datoulei - it's not supported yet...

@webron webron modified the milestones: v2.1.1, v2.1.2 Jun 24, 2015
@antoinebaudoux
Copy link

👍

@webron webron modified the milestones: v2.1.2, v2.1.3 Jul 31, 2015
@devigned
Copy link

devigned commented Sep 1, 2015

👍

@fehguy
Copy link
Contributor Author

fehguy commented Sep 1, 2015

Thanks @devigned. I'll try to get to this today or tomorrow. I've seen your issues in the ui on allOf as well

@devigned
Copy link

devigned commented Sep 1, 2015

Thank you, @fehguy!

Hopefully, the linking of the issues wasn't spammy, just wanted to help out by linking them together so folks can see the issue has been logged and is in progress.

@webron webron modified the milestones: v2.1.3, v2.1.4 Sep 2, 2015
@fehguy fehguy modified the milestones: v2.1.4, v2.1.8, v2.1.9 Nov 22, 2015
@fehguy fehguy removed this from the v2.1.8 milestone Nov 28, 2015
@fehguy fehguy modified the milestones: v2.1.9, v2.1.10 Dec 10, 2015
@abstratt
Copy link

abstratt commented Jan 1, 2016

@fehguy If this makes it into swagger-js 2.1.10, would swagger-ui require feature work or would it just be a matter of updating the version for the dependency on swagger-client? (I could not find any open issues tracking required work in swagger-ui itself.)

@fehguy
Copy link
Contributor Author

fehguy commented Jan 1, 2016

Hi, @abstratt that's correct. swagger-ui bundles swagger-js inside it directly.

@fehguy fehguy modified the milestones: v2.1.10, v2.1.11 Jan 4, 2016
@fehguy fehguy modified the milestones: v2.1.11, v2.1.12 Jan 14, 2016
@fehguy fehguy modified the milestones: v2.1.12, v2.1.14 Mar 2, 2016
@dgofman
Copy link

dgofman commented Jun 1, 2016

#783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants