Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title as model name for definition #2029

Closed
gaplyk opened this issue Mar 14, 2016 · 2 comments
Closed

Title as model name for definition #2029

gaplyk opened this issue Mar 14, 2016 · 2 comments
Milestone

Comments

@gaplyk
Copy link

gaplyk commented Mar 14, 2016

After generation of schema i'm getting

{
 "definitions" :{
   "SomeRequest": {
      "title": "Cool request structure.",
      "description": "This is request object.",
      "type": "object",
      "required": [
        "field"
      ],
      "properties": {
        "field": {
          "description": "Field is a string",
          "type": "string",
        }
      },
    },
 }
}

and on the page I see:

Cool request structure. { 
   field (string): Field is a string
}

I don't think this is appropriate to use title as Model Name.

@webron
Copy link
Contributor

webron commented Mar 16, 2016

Should be fixed by swagger-api/swagger-js#735.

@webron webron closed this as completed Mar 16, 2016
@stoicflame
Copy link

So, I hate to be contrary, but what if I liked using the title? When you're dealing with swagger.json files that have been generated by code generators, the model name is often ugly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants