Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to redux@4 #6332

Closed
tim-lai opened this issue Aug 20, 2020 · 1 comment
Closed

Migrate to redux@4 #6332

tim-lai opened this issue Aug 20, 2020 · 1 comment

Comments

@tim-lai
Copy link
Contributor

tim-lai commented Aug 20, 2020

Content & configuration

all config, plugin, etc.

Is your feature request related to a problem?

Redux@4 breaking change: Forbid subscribe() and getState() while reducer is running. Ref here

PR #6330 is related, and #6331 are reverted the dependency change back to redux@3.

Swagger Editor unit tests fail with following error message:

Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.

Swagger UI tests do not currently capture breaking changes from redux@4.

This change will require refactor changes to multiple reducer files.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@tim-lai
Copy link
Contributor Author

tim-lai commented Mar 28, 2022

closing as obsolete. SwaggerUI@4 implements React@17 and Redux@4

@tim-lai tim-lai closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant