-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sample-gen): allOf, oneOf lifting should consider properties and items #7041
Merged
tim-lai
merged 5 commits into
swagger-api:master
from
mathis-m:bug/props_not_passed_to_anyOf_oneOf
Mar 10, 2021
Merged
fix(sample-gen): allOf, oneOf lifting should consider properties and items #7041
tim-lai
merged 5 commits into
swagger-api:master
from
mathis-m:bug/props_not_passed_to_anyOf_oneOf
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relevant schema lifting util needs to consider properties Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
mathis-m
force-pushed
the
bug/props_not_passed_to_anyOf_oneOf
branch
from
March 6, 2021 16:42
698e1cd
to
b3f81ad
Compare
Signed-off-by: mathis-m <mathis.michel@outlook.de>
mathis-m
force-pushed
the
bug/props_not_passed_to_anyOf_oneOf
branch
from
March 6, 2021 16:51
b3f81ad
to
db05b6d
Compare
mathis-m
changed the title
fix(sample-gen): allOf, oneOf lifting should consider properties
fix(sample-gen): allOf, oneOf lifting should consider properties and items
Mar 6, 2021
@mathis-m PR merged! Thanks for the fix! |
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relevant schema lifting util needs to consider properties and items.
the properties logic was already in place but was not used for array items. Have moved it to the lifting util so it gets used in any case.
Motivation and Context
Fixes #7040
Fixes #7042
This was introduced with v3.39.0 by my commit 0f541a1.
There anyOf and oneOf was first introduced to the sample generator for schemas other then
array.items.anyOf
|array.items.oneOf
, unfortunately I did not handled the case were items or (properties inarray.item
schemas) are defined via anyOf or oneOf.How Has This Been Tested?
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests