Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems no dependency on gin-swagger (cyclic dependency ?) #563

Closed
gasuketsu opened this issue Nov 18, 2019 · 3 comments
Closed

Seems no dependency on gin-swagger (cyclic dependency ?) #563

gasuketsu opened this issue Nov 18, 2019 · 3 comments
Labels

Comments

@gasuketsu
Copy link

Describe the bug

It looks that current swag does not have dependency on gin-swagger though go.mod has dependency on gin-swagger@v1.2.0.
Due to this dependency, performing go mod tidy in project using echo-swagger fails with following error.

        github.com/swaggo/echo-swagger tested by
        github.com/swaggo/echo-swagger.test imports
        github.com/swaggo/gin-swagger/example/docs: module github.com/swaggo/gin-swagger@latest found (v1.2.0), but does not contain package github.com/swaggo/gin-swagger/example/docs

To Reproduce
Steps to reproduce the behavior:

  1. Create a 'go moduled' project depends on github.com/labstack/echo/v4 and github.com/swaggo/echo-swagger.
  2. Perform go mod tidy in the project

Expected behavior
go mod tidy completes w/o error.

Screenshots
n/a

Your swag version

1.6.3

Your go version

1.13.4

@ubogdan
Copy link
Contributor

ubogdan commented Jan 8, 2020

@gasuketsu GO is right, there is no docs package in swaggo/gin-swagger/example for version 1.2.0 as swagg/go.mod is describing.

@ubogdan ubogdan assigned ubogdan and unassigned ubogdan Jan 8, 2020
@ubogdan ubogdan added the bug label Jan 8, 2020
@akojo
Copy link
Contributor

akojo commented Nov 23, 2020

#800 along with swaggo/echo-swagger#33 should fix this issue

@ubogdan
Copy link
Contributor

ubogdan commented Sep 28, 2021

Closing: fixed.

@ubogdan ubogdan closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants