Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required Go version in readme is wrong #913

Closed
andymcn opened this issue Apr 13, 2021 · 1 comment
Closed

Required Go version in readme is wrong #913

andymcn opened this issue Apr 13, 2021 · 1 comment
Labels
docs

Comments

@andymcn
Copy link

andymcn commented Apr 13, 2021

The project README.md clearly states that version 1.9 or newer of Go is needed. However, parser.go uses strings.ReplaceAll, which was introduced in 1.12.

Either the use of 1.12 functions should be removed or the readme should be updated to reflect reality.
@ubogdan
Copy link
Contributor

ubogdan commented Apr 13, 2021

the CI doesn't test the code against go 1.9 anymore and I believe updating the docs should be the best approach.

@ubogdan ubogdan mentioned this issue Apr 13, 2021
Merged
@ubogdan ubogdan added the docs label Apr 13, 2021
@ubogdan ubogdan closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ubogdan @andymcn