Small changes to DRY up list.rb #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| acts_as_list_class.unscoped do | ||
| acts_as_list_class.in_list.where(scope_condition).where(conditions).order("#{acts_as_list_class.table_name}.#{position_column} DESC").first | ||
| end | ||
| acts_as_list_list.in_list.where(conditions).order("#{acts_as_list_class.table_name}.#{position_column} DESC").first |
| acts_as_list_class.in_list.where(scope_condition).where(conditions).order("#{acts_as_list_class.table_name}.#{position_column} DESC").first | ||
| end | ||
| acts_as_list_list.in_list.where( | ||
| conditions |
There was a problem hiding this comment.
Indent the first parameter one step more than the previous line.
|
Looks good to me. @brendon : Any thoughts? |
|
Yep, looks good to me too :) Well done. SO DRY :) |
swanandp
added a commit
that referenced
this pull request
Jul 7, 2015
Small changes to DRY up list.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a few small changes to reuse already implemented convenience methods.