Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test round-tripping of save + achievement data files in CI #1869

Open
byorgey opened this issue May 27, 2024 · 1 comment
Open

Test round-tripping of save + achievement data files in CI #1869

byorgey opened this issue May 27, 2024 · 1 comment
Labels
C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-Testing Involves the testing suite - unit and integration tests, also benchmarks. Z-CI This issue is about continuous integration pipelines - GH Actions - tests and releases on server.

Comments

@byorgey
Copy link
Member

byorgey commented May 27, 2024

More generally, we should add something to our CI that makes sure we can round-trip save files + achievement data.

Originally posted by @byorgey in #1868 (comment)
@byorgey byorgey mentioned this issue May 31, 2024
Merged
@byorgey byorgey added C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-CI This issue is about continuous integration pipelines - GH Actions - tests and releases on server. labels Jun 1, 2024
@kostmo
Copy link
Member

kostmo commented Jun 16, 2024

Related: #1507

@byorgey byorgey added the T-Testing Involves the testing suite - unit and integration tests, also benchmarks. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Moderate Effort Should take a moderate amount of time to address. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-Testing Involves the testing suite - unit and integration tests, also benchmarks. Z-CI This issue is about continuous integration pipelines - GH Actions - tests and releases on server.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kostmo @byorgey