feat: remove babelrc and babel.config from babel-loader

If present, it could conflict with tooling when used in a wrong way. We already provide jsBabelOverride for that, so if needed user can enable it again. Closes #11
swashata · Oct 20, 2018 · 31d8635 · 31d8635
1 parent e2df10f
commit 31d8635
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap b/packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap
@@ -32,6 +32,8 @@ Object {
         Object {
           "loader": "babel-loader",
           "options": Object {
+            "babelrc": false,
+            "configFile": false,
             "presets": Array [
               Array [
                 "@wpackio/base",
@@ -51,6 +53,8 @@ Object {
         Object {
           "loader": "babel-loader",
           "options": Object {
+            "babelrc": false,
+            "configFile": false,
             "presets": Array [
               Array [
                 "@wpackio/base",

diff --git a/packages/scripts/src/config/WebpackConfigHelper.ts b/packages/scripts/src/config/WebpackConfigHelper.ts
@@ -325,6 +325,11 @@ ${bannerConfig.copyrightText}${bannerConfig.credit ? creditNote : ''}`,
 					options: this.getOverrideWebpackRuleOptions(
 						{
 							presets: jsPresets,
+							// disable babelrc and babel.config.js
+							// as it could potentially break stuff
+							// rather use the jsBabelOverride
+							configFile: false,
+							babelrc: false,
 						},
 						this.config.jsBabelOverride
 					),
@@ -352,6 +357,11 @@ ${bannerConfig.copyrightText}${bannerConfig.credit ? creditNote : ''}`,
 					options: this.getOverrideWebpackRuleOptions(
 						{
 							presets: tsPresets,
+							// disable babelrc and babel.config.js
+							// as it could potentially break stuff
+							// rather use the jsBabelOverride
+							configFile: false,
+							babelrc: false,
 							// We don't need plugin-proposal-class-properties
 							// because taken care of by @wpackio/base
 							// '@babel/proposal-class-properties',