Skip to content

Commit 3fc2423

Browse files
committed
feat: remove webpack dashboard because it doesn't work
I don't know why! πŸ˜•
1 parent bc38690 commit 3fc2423

File tree

3 files changed

+3
-29
lines changed

3 files changed

+3
-29
lines changed

β€Žpackages/scripts/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
"style-loader": "^0.23.0",
4545
"uglifyjs-webpack-plugin": "^2.0.1",
4646
"webpack": "^4.20.2",
47-
"webpack-dashboard": "^2.0.0",
4847
"webpack-dev-middleware": "^3.4.0",
4948
"webpack-hot-middleware": "^2.24.0",
5049
"webpack-merge": "^4.1.4"

β€Žpackages/scripts/src/bin/index.ts

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,6 @@ program
8787
signale.star('To spread the ❀️ please tweet.');
8888
process.exit(0);
8989
});
90-
process.on('SIGKILL', () => {
91-
server.stop();
92-
});
93-
process.on('SIGTERM', () => {
94-
server.stop();
95-
});
9690
} catch (e) {
9791
signale.error(
9892
'Could not start development server. Please check the log below.'
@@ -263,21 +257,3 @@ function getProjectAndServerConfig(
263257

264258
return { projectConfig, serverConfig, projectConfigPath, serverConfigPath };
265259
}
266-
267-
// Error out on force close
268-
process.on('SIGKILL', () => {
269-
signale.fatal(
270-
'The operation failed because the process exited too early. ' +
271-
'This probably means the system ran out of memory or someone called ' +
272-
'`kill -9` on the process.'
273-
);
274-
process.exit(1);
275-
});
276-
process.on('SIGTERM', () => {
277-
signale.fatal(
278-
'The operation failed because the process exited too early. ' +
279-
'Someone might have called `kill` or `killall`, or the system could ' +
280-
'be shutting down.'
281-
);
282-
process.exit(1);
283-
});

β€Žpackages/scripts/src/scripts/Server.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import browserSync from 'browser-sync';
22
import webpack from 'webpack';
3-
import DashboardPlugin from 'webpack-dashboard/plugin';
43
import webpackDevMiddleware from 'webpack-dev-middleware';
54
import webpackHotMiddleware from 'webpack-hot-middleware';
65

@@ -48,8 +47,8 @@ export class Server {
4847
'Can not serve while the server is already running.'
4948
);
5049
}
51-
// Init browserSync
52-
const bs = browserSync.init();
50+
// Create browserSync Instance
51+
const bs = browserSync.create();
5352
// Create configuration
5453
const webpackConfig = new CreateWebpackConfig(
5554
this.projectConfig,
@@ -89,7 +88,7 @@ export class Server {
8988
});
9089
} else {
9190
const compiler = webpack(webpackConfig);
92-
compiler.apply(new DashboardPlugin());
91+
// compiler.apply(new DashboardPlugin());
9392
const devMiddleware = webpackDevMiddleware(compiler, {
9493
stats: { colors: true },
9594
publicPath:

0 commit comments

Comments
Β (0)