Skip to content

Commit

Permalink
fix: update e2e deps and fix issue with execa
Browse files Browse the repository at this point in the history
Instead of using shellSync, we now rely on new API, commandSync.
  • Loading branch information
swashata committed Oct 27, 2019
1 parent da2b87a commit 59de130
Show file tree
Hide file tree
Showing 6 changed files with 1,771 additions and 1,689 deletions.
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ root = true

[*]
indent_style = tab
indent_size = 4
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
Expand Down
4 changes: 2 additions & 2 deletions e2e/cypress/plugins/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = (on, config) => {
on('task', {
hmrJs: () => {
fs.writeFileSync(jsFilePath, `${jsFileContent}\n// HMR`);
execa.shellSync(`touch ${jsFilePath}`);
execa.commandSync(`touch ${jsFilePath}`);
return null;
},
hmrJsRestore: () => {
Expand All @@ -32,7 +32,7 @@ module.exports = (on, config) => {
},
hmrTs: () => {
fs.writeFileSync(tsFilePath, `${tsFileContent}\n// HMR`);
execa.shellSync(`touch ${tsFilePath}`);
execa.commandSync(`touch ${tsFilePath}`);
return null;
},
hmrTsRestore: () => {
Expand Down
33 changes: 16 additions & 17 deletions e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
"license": "MIT",
"private": true,
"devDependencies": {
"@types/jest": "24.0.17",
"@types/jest": "24.0.20",
"@wpackio/scripts": "file:../packages/scripts",
"autoprefixer": "9.6.1",
"autoprefixer": "9.7.0",
"cssnano": "4.1.10",
"cypress": "3.4.1",
"fork-ts-checker-webpack-plugin": "1.5.0",
"jest": "24.8.0",
"less": "3.9.0",
"node-sass": "4.12.0",
"serve": "11.1.0",
"typescript": "3.5.3",
"cypress": "3.5.0",
"fork-ts-checker-webpack-plugin": "2.0.0",
"jest": "24.9.0",
"less": "3.10.3",
"node-sass": "4.13.0",
"serve": "11.2.0",
"typescript": "3.6.4",
"wait-on": "3.3.0"
},
"scripts": {
Expand All @@ -34,14 +34,13 @@
"test": "jest --color"
},
"dependencies": {
"@types/execa": "0.9.0",
"@types/webpack-env": "1.14.0",
"@types/webpack-env": "1.14.1",
"@wpackio/entrypoint": "file:../packages/entrypoint",
"execa": "1.0.0",
"react": "16.9.0",
"react-bootstrap": "1.0.0-beta.11",
"react-dom": "16.9.0",
"react-hot-loader": "4.12.11",
"uuid": "3.3.2"
"execa": "3.2.0",
"react": "16.11.0",
"react-bootstrap": "1.0.0-beta.14",
"react-dom": "16.11.0",
"react-hot-loader": "4.12.15",
"uuid": "3.3.3"
}
}
2 changes: 2 additions & 0 deletions e2e/src/app/dynamic.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
export function dynamic(node, text = 'I am dynamically imported') {
node.textContent = text;
}

// HMR
2 changes: 2 additions & 0 deletions e2e/src/tsapp/module.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
export function updateText(node: Node, text: string): void {
node.textContent = text;
}

// HMR
Loading

0 comments on commit 59de130

Please sign in to comment.