Skip to content

Commit 59de130

Browse files
committed
fix: update e2e deps and fix issue with execa
Instead of using shellSync, we now rely on new API, commandSync.
1 parent da2b87a commit 59de130

File tree

6 files changed

+1771
-1689
lines changed

6 files changed

+1771
-1689
lines changed

.editorconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ root = true
22

33
[*]
44
indent_style = tab
5-
indent_size = 4
5+
indent_size = 2
66
end_of_line = lf
77
charset = utf-8
88
trim_trailing_whitespace = true

e2e/cypress/plugins/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module.exports = (on, config) => {
2323
on('task', {
2424
hmrJs: () => {
2525
fs.writeFileSync(jsFilePath, `${jsFileContent}\n// HMR`);
26-
execa.shellSync(`touch ${jsFilePath}`);
26+
execa.commandSync(`touch ${jsFilePath}`);
2727
return null;
2828
},
2929
hmrJsRestore: () => {
@@ -32,7 +32,7 @@ module.exports = (on, config) => {
3232
},
3333
hmrTs: () => {
3434
fs.writeFileSync(tsFilePath, `${tsFileContent}\n// HMR`);
35-
execa.shellSync(`touch ${tsFilePath}`);
35+
execa.commandSync(`touch ${tsFilePath}`);
3636
return null;
3737
},
3838
hmrTsRestore: () => {

e2e/package.json

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@
77
"license": "MIT",
88
"private": true,
99
"devDependencies": {
10-
"@types/jest": "24.0.17",
10+
"@types/jest": "24.0.20",
1111
"@wpackio/scripts": "file:../packages/scripts",
12-
"autoprefixer": "9.6.1",
12+
"autoprefixer": "9.7.0",
1313
"cssnano": "4.1.10",
14-
"cypress": "3.4.1",
15-
"fork-ts-checker-webpack-plugin": "1.5.0",
16-
"jest": "24.8.0",
17-
"less": "3.9.0",
18-
"node-sass": "4.12.0",
19-
"serve": "11.1.0",
20-
"typescript": "3.5.3",
14+
"cypress": "3.5.0",
15+
"fork-ts-checker-webpack-plugin": "2.0.0",
16+
"jest": "24.9.0",
17+
"less": "3.10.3",
18+
"node-sass": "4.13.0",
19+
"serve": "11.2.0",
20+
"typescript": "3.6.4",
2121
"wait-on": "3.3.0"
2222
},
2323
"scripts": {
@@ -34,14 +34,13 @@
3434
"test": "jest --color"
3535
},
3636
"dependencies": {
37-
"@types/execa": "0.9.0",
38-
"@types/webpack-env": "1.14.0",
37+
"@types/webpack-env": "1.14.1",
3938
"@wpackio/entrypoint": "file:../packages/entrypoint",
40-
"execa": "1.0.0",
41-
"react": "16.9.0",
42-
"react-bootstrap": "1.0.0-beta.11",
43-
"react-dom": "16.9.0",
44-
"react-hot-loader": "4.12.11",
45-
"uuid": "3.3.2"
39+
"execa": "3.2.0",
40+
"react": "16.11.0",
41+
"react-bootstrap": "1.0.0-beta.14",
42+
"react-dom": "16.11.0",
43+
"react-hot-loader": "4.12.15",
44+
"uuid": "3.3.3"
4645
}
4746
}

e2e/src/app/dynamic.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@
22
export function dynamic(node, text = 'I am dynamically imported') {
33
node.textContent = text;
44
}
5+
6+
// HMR

e2e/src/tsapp/module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
export function updateText(node: Node, text: string): void {
22
node.textContent = text;
33
}
4+
5+
// HMR

0 commit comments

Comments
 (0)