Skip to content

Commit ed5edb1

Browse files
committed
feat: use modern browser target during dev
This speeds up development hot-reload time. Closes #12
1 parent 31d8635 commit ed5edb1

File tree

2 files changed

+31
-2
lines changed

2 files changed

+31
-2
lines changed

packages/scripts/__tests__/config/__snapshots__/WebpackConfigHelper.spec.ts.snap

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,13 @@ Object {
3939
"@wpackio/base",
4040
Object {
4141
"hasReact": true,
42+
"presetEnv": Object {
43+
"targets": Object {
44+
"chrome": "69",
45+
"edge": "17",
46+
"firefox": "62",
47+
},
48+
},
4249
},
4350
],
4451
],
@@ -60,6 +67,13 @@ Object {
6067
"@wpackio/base",
6168
Object {
6269
"hasReact": true,
70+
"presetEnv": Object {
71+
"targets": Object {
72+
"chrome": "69",
73+
"edge": "17",
74+
"firefox": "62",
75+
},
76+
},
6377
},
6478
],
6579
Array [

packages/scripts/src/config/WebpackConfigHelper.ts

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -303,12 +303,27 @@ ${bannerConfig.copyrightText}${bannerConfig.credit ? creditNote : ''}`,
303303
*/
304304
public getModule(): webpack.Module {
305305
const { hasReact, hasSass, hasFlow } = this.config;
306+
const wpackioBabelOptions: PresetOptions = {
307+
hasReact,
308+
};
309+
// Push targets to babel-preset-env if this is dev
310+
// We target only the latest chrome and firefox for
311+
// greater speed
312+
if (this.isDev) {
313+
wpackioBabelOptions.presetEnv = {
314+
targets: {
315+
chrome: '69',
316+
firefox: '62',
317+
edge: '17',
318+
},
319+
};
320+
}
306321
// create the babel rules for es6+ code
307322
const jsPresets: babelPreset[] = [
308323
[
309324
'@wpackio/base',
310325
this.getBabelPresetOptions(
311-
{ hasReact },
326+
wpackioBabelOptions,
312327
this.config.jsBabelPresetOptions
313328
),
314329
],
@@ -343,7 +358,7 @@ ${bannerConfig.copyrightText}${bannerConfig.credit ? creditNote : ''}`,
343358
[
344359
'@wpackio/base',
345360
this.getBabelPresetOptions(
346-
{ hasReact },
361+
wpackioBabelOptions,
347362
this.config.tsBabelPresetOptions
348363
),
349364
],

0 commit comments

Comments
 (0)