Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] use multi-value wasm for the plugin runner #7497

Closed
kwonoj opened this issue Jun 6, 2023 · 2 comments
Closed

[Tracking] use multi-value wasm for the plugin runner #7497

kwonoj opened this issue Jun 6, 2023 · 2 comments

Comments

@kwonoj
Copy link
Member

kwonoj commented Jun 6, 2023

Describe the feature

Currently, we use a wrapper struct contains ptr to the actual data to pass over data between plugin host to the plugin.

This is due to compiled wasm binary didn't support returning multi-value; i.e we could do simplifed way instead

fn some_fn() -> (ptr, len);

and receiver directly deserialize it if it was possible. We once enabled this with custom-patch, but that was too cumbersome to ask to all of the plugin authors.

It looks like recent compiler started to support it, so we may able to try this again.

However this is somewhat large breaking changes to the plugins

  1. interface change requires to bump up swc_core
  2. All of the plugin requires to compile with specific flag (--multi-value).

Babel plugin or link to the feature description

No response

Additional context

rust-lang/rust#73755 (comment)

@kdy1 kdy1 added this to the Planned milestone Jun 7, 2023
@kwonoj
Copy link
Member Author

kwonoj commented Jul 26, 2023

For now not going to pursue this as it requires all of the plugin author to compile with specific flags.

@kwonoj kwonoj closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.72 Jul 28, 2023
@swc-bot
Copy link
Collaborator

swc-bot commented Aug 28, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants