Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links need to be fixed in CONTRIBUTING.md #835

Closed
tobyhodges opened this issue Jun 2, 2023 · 1 comment
Closed

Links need to be fixed in CONTRIBUTING.md #835

tobyhodges opened this issue Jun 2, 2023 · 1 comment

Comments

@tobyhodges
Copy link
Member

The Contributing Guide, CONTRIBUTING.md, contains two links with URLs that should be updated:

  1. the How to Contribute to an Open Source Project on GitHub link leads to a 404 and should be updated to link to https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github
  2. the [repo] link reference currently points to a placeholder URL (https://example.com/FIXME) and should be updated to point to the source repository for the lesson (i.e. this GitHub repository).

The Contributing Guide is one of the files that is unique to each repository - to allow for individual lesson projects to define their own guidance for contributors - so unfortunately this is not an issue that can be fixed centrally e.g. by updating the template files in the lesson infrastructure. Instead the file must be updated in the individual lesson repositories themselves.

@matthieu-bruneaux
Copy link
Contributor

Thank you @tobyhodges! This was fixed by merging PR #836 from @JCSzamosi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants