Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests and create a CI pipeline #38

Open
SebastinSanty opened this issue Jan 12, 2018 · 6 comments
Open

Write tests and create a CI pipeline #38

SebastinSanty opened this issue Jan 12, 2018 · 6 comments

Comments

@SebastinSanty
Copy link
Member

No description provided.

@adiasg
Copy link
Collaborator

adiasg commented Feb 10, 2018

Merge with #53?

@SebastinSanty
Copy link
Member Author

SebastinSanty commented Feb 10, 2018

Hmm, this issue is for Django/React Unit Tests, which we can setup on some already available CI like Travis or Circle. I am not sure if we'll gain any advantage having a custom Jenkins setup.

I think #53 and this issue, have only webhooks in common. I guess these two issues would have been similar if we using a custom CI for testing. But Travis/Circle manages everything in their backend, we'll have to only worry about correct .yml configs.

@SebastinSanty
Copy link
Member Author

@mayankanchlia Can you take this up?

@mayankanchlia
Copy link
Collaborator

@SebastinSanty yes definitely, I'll take this.

@mayankanchlia
Copy link
Collaborator

@SebastinSanty Travis ci does not support private repo in the free version and have to pay on a monthly basis so it goes out of the option. I'll start working on the circle CI as of now.

@SebastinSanty
Copy link
Member Author

Yes, Circle CI is also a great option, though I am not sure how exactly it differs from Travis. I'll find more information about it.

Also, regarding the issue of private repo, we'll be soon moving this to a public repository after #70 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants