Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecodingError type conflicts with Foundation's DecodingError #24

Closed
patrickfreed opened this issue Jan 12, 2021 · 0 comments · Fixed by #25
Closed

DecodingError type conflicts with Foundation's DecodingError #24

patrickfreed opened this issue Jan 12, 2021 · 0 comments · Fixed by #25

Comments

@patrickfreed
Copy link
Contributor

The DecodingError type included in this library shares a name with the DecodingError from Foundation, requiring users of both libraries manually disambiguate. This is particularly noticeable when importing ExtrasBase64 into an existing codebase, since all existing references to Foundation's DecodingError need to be updated in order to compile. Ideally, the type introduced in this library could use a unique prefix to ensure this clash doesn't occur (e.g. ExtrasBase64DecodingErrror).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant