-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy Resources from External Dependencies into Archived Zip #367
Comments
I was able to work around this by adding my own script which adds the needed resources to the zip file, but it would be great if it worked automatically. |
We should fix this in the Packager plugin. Do we need to go through all the dependencies and check if they have resources? I assume so. |
I am currently experiencing the same problem. Until there is a solution integrated into plugin. Could you share your solution here? |
Yeah I think so. The resources get put automatically in I have added these lines to my local script to make it work: |
@fabianfett I put up a pr here that I believe should fix it (testing locally works) #386. Let me know what you think and what the next steps of the process are for pull requests! |
Expected behavior
When adding a third-party dependency, I would expect the zip file to correctly have the resources of all dependencies.
Actual behavior
When adding a 3rd party dependency (https://github.com/awslabs/aws-sdk-swift was what happened with me), the resources files for the dependencies were not added to the final zip. This caused an issue when trying to start up the lambda.
Steps to reproduce
If possible, minimal yet complete reproducer code (or URL to code)
No response
What version of this project (
swift-aws-lambda-runtime
) are you using?1.0.0-alpha-3
Swift version
Swift 5.10
Amazon Linux 2 docker image version
No response
The text was updated successfully, but these errors were encountered: