Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on SwiftkubeModel is too loose #10

Closed
allenhsu opened this issue Sep 1, 2021 · 1 comment
Closed

Dependency on SwiftkubeModel is too loose #10

allenhsu opened this issue Sep 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@allenhsu
Copy link

allenhsu commented Sep 1, 2021

It seems that minor versions of SwiftkubeModel are not backward compatible. For example settings has been removed from SwiftkubeModel 0.4.0, however it's used in SwiftkubeClient 0.9.0. So installing SwiftkubeClient 0.9.0 without manually pinning SwiftkubeModel to 0.3.x in the main project would cause the project failing to compile.

So, I would recommend updating the dependency on SwiftkubeModel to upToNextMinor in Package.swift.
@iabudiab
Copy link
Member

iabudiab commented Sep 1, 2021

@allenhsu Yes, you are absolutely right. From SwiftkubeClient 0.10.0 forward it will be the case, which will be released this week.

@iabudiab iabudiab added the bug Something isn't working label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allenhsu @iabudiab