Skip to content

Add performance measurements to PR checks? #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allevato opened this issue Mar 20, 2025 · 1 comment
Open

Add performance measurements to PR checks? #967

allevato opened this issue Mar 20, 2025 · 1 comment

Comments

@allevato
Copy link
Member

Based on the comment in #957 (comment).

I'm wondering if there's a way we can set up a GitHub action to do a performance run on PRs. It would be nice to have this automatically reported on every PR somehow, to better avoid regressions.

Can we check out and build main in release mode, then run swift-format over itself a few times with --measure-instructions and compute some stats (mean, std dev), then do the same with the PR, and report the diff? We'd probably want to do this in both format and lint mode.

@ahoppen
Copy link
Member

ahoppen commented Mar 20, 2025

Synced to Apple’s issue tracker as rdar://147492596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants