Build: create static libraries explicitly with libtool.

drodriguez · drodriguez · commit 72427eeb092e · 2022-12-05T18:47:38.000-08:00
This matches the implementation of the static linker in swift-driver, which always adds the explicit `-static`. https://github.com/apple/swift-driver/blob/caa81e560362a4e14034cd4502114d03e45ea261/Sources/SwiftDriver/Jobs/DarwinToolchain%2BLinkerSupport.swift#L95-L102
diff --git a/Sources/Build/BuildPlan.swift b/Sources/Build/BuildPlan.swift
@@ -1387,7 +1387,7 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription
             return [librarian, "/LIB", "/OUT:\(binaryPath.pathString)", "@\(linkFileListPath.pathString)"]
         }
         if triple.isDarwin(), librarian.hasSuffix("libtool") {
-            return [librarian, "-o", binaryPath.pathString, "@\(linkFileListPath.pathString)"]
+            return [librarian, "-static", "-o", binaryPath.pathString, "@\(linkFileListPath.pathString)"]
         }
         return [librarian, "crs", binaryPath.pathString, "@\(linkFileListPath.pathString)"]
     }

Original file line number	Diff line number	Diff line change
`@@ -1387,7 +1387,7 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription`
`1387`	`1387`	`return [librarian, "/LIB", "/OUT:\(binaryPath.pathString)", "@\(linkFileListPath.pathString)"]`
`1388`	`1388`	`}`
`1389`	`1389`	`if triple.isDarwin(), librarian.hasSuffix("libtool") {`
`1390`		`- return [librarian, "-o", binaryPath.pathString, "@\(linkFileListPath.pathString)"]`
	`1390`	`+ return [librarian, "-static", "-o", binaryPath.pathString, "@\(linkFileListPath.pathString)"]`
`1391`	`1391`	`}`
`1392`	`1392`	`return [librarian, "crs", binaryPath.pathString, "@\(linkFileListPath.pathString)"]`
`1393`	`1393`	`}`