Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: Add windows "self-hosted" pipeline equivalent #8176

Open
1 task done
bkhouri opened this issue Dec 16, 2024 · 2 comments
Open
1 task done

Pipeline: Add windows "self-hosted" pipeline equivalent #8176

bkhouri opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines enhancement windows

Comments

@bkhouri
Copy link
Contributor

bkhouri commented Dec 16, 2024

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

The current Windows PR CI pipeline build the toolchain, but does not execute any tests. In order to ensure we don't regress on windows, it would be ideal to execute the tests on Windows.

However, the tests on Windows currently fail (See #8121). In order to gain confidence, we should add an Windows Self-hosted CI pipeline before enabling tests on the the current Swift Test Windows Platform Pipeline

However, we should be able to demand the "Windows self-host PR CI pipeline" on-demand, to ensure we introduce passing test in the same PR as the enabling the pipeline itself.

Expected behavior

  • Can demand the "Windows Self-hosted CI pipeline" against a PR
  • The "Windows self-hosted CI pipeline" becomes gating after the PR is merged or after some soak time

Actual behavior

N/A

Steps to reproduce

N/A

Swift Package Manager version/commit hash

N/A

Swift & OS version (output of swift --version ; uname -a)

N/A

@bkhouri bkhouri added the bug label Dec 16, 2024
@shahmishal
Copy link
Member

Can you please share the script self-hosted CI pipeline would execute?

@bkhouri bkhouri added enhancement continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines windows and removed bug labels Dec 20, 2024
@bkhouri bkhouri self-assigned this Dec 20, 2024
@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 20, 2024

We don't have a script yet. I was hoping to have a discussion to determine the best course of action. Until we have this discussion, I'll try running the test in a docker image

e.g.:

docker run -v C:\Users\swift-ci\jenkins\workspace\swift-main-swift-main-windows:C:\source swiftlang/swift:nightly-windowsservercore-1809 cmd /s /c "swift test"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines enhancement windows
Projects
None yet
Development

No branches or pull requests

2 participants