Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Traits] swift package edit and swift package unedit should support trait options #8354

Open
1 task done
bripeticca opened this issue Mar 11, 2025 · 0 comments · May be fixed by #8417
Open
1 task done

[Traits] swift package edit and swift package unedit should support trait options #8354

bripeticca opened this issue Mar 11, 2025 · 0 comments · May be fixed by #8417
Assignees
Labels

Comments

@bripeticca
Copy link
Contributor

Is it reproducible with SwiftPM command-line tools: swift build, swift test, swift package etc?

  • Confirmed reproduction steps with SwiftPM CLI. The description text must include reproduction steps with either of command-line SwiftPM commands, swift build, swift test, swift package etc.

Description

The swift package edit and swift package unedit commands don't currently support passing in a trait configuration despite having a path for computing dependency resolution - this will disrupt the dependency graph for packages relying on enabled/disabled trait configurations.

Expected behavior

The edit and unedit commands should support traits (as swift run, swift build, swift package resolve etc. do) in their available options.

Actual behavior

Traits are not supported as a current option.

Steps to reproduce

No concrete steps of reproduction besides taking note of the fact that there is no entry point into swift package edit and swift package unedit for configuring traits - can make note of this in both the source code where the command structs themselves do not have a TraitOptions property, and in CLI when running swift package edit --help/swift package unedit --help.

Swift Package Manager version/commit hash

No response

Swift & OS version (output of swift --version ; uname -a)

No response

@bripeticca bripeticca added the bug label Mar 11, 2025
@bripeticca bripeticca self-assigned this Mar 11, 2025
@bripeticca bripeticca changed the title swift package edit and swift package unedit should support trait options [Traits] swift package edit and swift package unedit should support trait options Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant