Insert a space before colon in ternary expression

Author: gibachan

Sources/SwiftParserDiagnostics/ParseDiagnosticsGenerator.swift

@@ -1456,7 +1456,7 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor {
             FixIt(
               message: InsertTokenFixIt(missingNodes: [Syntax(node.colonMark), Syntax(nextSibling)]),
               changes: [
-                .makePresent(node.colonMark),
+                .makePresent(node.colonMark, leadingTrivia: .space),
                 .makePresent(nextSibling),
               ]
             )

Tests/SwiftParserTest/DeclarationTests.swift

@@ -256,7 +256,7 @@ final class DeclarationTests: XCTestCase {
         DiagnosticSpec(message: "expected ':' and expression after '? ...' in ternary expression", fixIts: ["insert ':' and expression"])
       ],
       fixedSource: """
-        _ = foo/* */?.description: <#expression#>
+        _ = foo/* */?.description : <#expression#>
         """
     )
 

Tests/SwiftParserTest/ExpressionTests.swift

@@ -836,7 +836,7 @@ final class ExpressionTests: XCTestCase {
         DiagnosticSpec(message: "expected ':' and expression after '? ...' in ternary expression", fixIts: ["insert ':' and expression"])
       ],
       fixedSource: """
-        foo ? 1: <#expression#>
+        foo ? 1 : <#expression#>
         """
     )
   }

Tests/SwiftParserTest/translated/InvalidIfExprTests.swift

@@ -23,7 +23,7 @@ final class InvalidIfExprTests: XCTestCase {
       diagnostics: [
         DiagnosticSpec(message: "expected ':' and expression after '? ...' in ternary expression", fixIts: ["insert ':' and expression"])
       ],
-      fixedSource: "(a ? b: <#expression#>)"
+      fixedSource: "(a ? b : <#expression#>)"
     )
   }
 
@@ -35,7 +35,7 @@ final class InvalidIfExprTests: XCTestCase {
       diagnostics: [
         DiagnosticSpec(message: "expected ':' and expression after '? ...' in ternary expression", fixIts: ["insert ':' and expression"])
       ],
-      fixedSource: "(a ? b : c ? d: <#expression#>)"
+      fixedSource: "(a ? b : c ? d : <#expression#>)"
     )
   }
 
@@ -52,7 +52,7 @@ final class InvalidIfExprTests: XCTestCase {
           fixIts: ["insert ')'"]
         ),
       ],
-      fixedSource: "(a ? b ? c : d: <#expression#>)"
+      fixedSource: "(a ? b ? c : d : <#expression#>)"
     )
   }
 
@@ -65,7 +65,7 @@ final class InvalidIfExprTests: XCTestCase {
         DiagnosticSpec(message: "expected ':' and expression after '? ...' in ternary expression", fixIts: ["insert ':' and expression"]),
         DiagnosticSpec(message: "expected ':' and expression after '? ...' in ternary expression", fixIts: ["insert ':' and expression"]),
       ],
-      fixedSource: "(a ? b ? c: <#expression#>: <#expression#>)"
+      fixedSource: "(a ? b ? c : <#expression#> : <#expression#>)"
     )
   }