Skip to content

Commit 6ede1c2

Browse files
committedJul 20, 2024·
[android][build-script] Update the default arch to AArch64, as that is by far the most commonly used now

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎utils/build_swift/build_swift/driver_arguments.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1393,7 +1393,7 @@ def create_argument_parser():
13931393

13941394
option('--android-arch', store,
13951395
choices=['armv7', 'aarch64', 'x86_64'],
1396-
default='armv7',
1396+
default='aarch64',
13971397
help='The target architecture when building for Android. '
13981398
'Currently, only armv7, aarch64, and x86_64 are supported. '
13991399
'%(default)s is the default.')

‎utils/build_swift/tests/expected_options.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
'android_api_level': '21',
4242
'android_deploy_device_path': '/data/local/tmp',
4343
'android_ndk': None,
44-
'android_arch': 'armv7',
44+
'android_arch': 'aarch64',
4545
'assertions': True,
4646
'benchmark': False,
4747
'benchmark_num_o_iterations': 3,
@@ -764,7 +764,7 @@ class BuildScriptImplOption(_BaseOption):
764764
ChoicesOption('--swift-analyze-code-coverage',
765765
choices=['false', 'not-merged', 'merged']),
766766
ChoicesOption('--android-arch',
767-
choices=['armv7', 'aarch64']),
767+
choices=['armv7', 'aarch64', 'x86_64']),
768768

769769
StrOption('--android-api-level'),
770770
StrOption('--build-args'),

0 commit comments

Comments
 (0)
Please sign in to comment.