Skip to content

Commit f547826

Browse files
AnthonyLatsisAnthonyLatsis
authored
Merge pull request #60894 from AnthonyLatsis/migrate-test-suite-to-gh-issues-16
Gardening: Migrate test suite to GH issues p. 16
2 parents 1665778 + 4591933 commit f547826

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+131
-85
lines changed

‎test/IRGen/associated_type_witness.swift‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ struct UsesVoid : HasSimpleAssoc {
151151
typealias Assoc = ()
152152
}
153153

154-
// SR-11642: Failure to canonicalize type in associated type witness.
154+
// https://github.com/apple/swift/issues/54052
155+
// Failure to canonicalize type in associated type witness
156+
155157
struct Validator<T> {
156158
let validatorFailureType: Any.Type
157159
}

‎test/IRGen/async/partial_apply.sil‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,9 @@ bb0(%0 : $Int):
299299
// CHECK-LABEL: define internal swift{{(tail)?}}cc void @"$s24complex_generic_functionTA"(
300300
struct ComplexBoundedType<T: P2> {}
301301

302-
// SR-901: Ensure that a partial_apply which captures bound generic type
303-
// metadata doesn't crash when restoring the generic context.
302+
// https://github.com/apple/swift/issues/43513
303+
// Ensure that a 'partial_apply' which captures bound generic type metadata
304+
// doesn't crash when restoring the generic context.
304305

305306
sil hidden @generic_function : $@async @convention(thin) <T> () -> () {
306307
%0 = builtin "int_trap"() : $Never

‎test/IRGen/big_types_corner_cases.swift‎

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -261,76 +261,77 @@ class ClassWithLoadableStructWithBiggerString {
261261
}
262262

263263
//===----------------------------------------------------------------------===//
264-
// SR-8076
264+
// https://github.com/apple/swift/issues/50609
265265
//===----------------------------------------------------------------------===//
266-
public typealias sr8076_Filter = (BigStruct) -> Bool
267266

268-
public protocol sr8076_Query {
267+
public typealias Filter = (BigStruct) -> Bool
268+
269+
public protocol Query {
269270
associatedtype Returned
270271
}
271272

272-
public protocol sr8076_ProtoQueryHandler {
273-
func forceHandle_1<Q: sr8076_Query>(query: Q) -> Void
274-
func forceHandle_2<Q: sr8076_Query>(query: Q) -> (Q.Returned, BigStruct?)
275-
func forceHandle_3<Q: sr8076_Query>(query: Q) -> (Q.Returned, sr8076_Filter?)
276-
func forceHandle_4<Q: sr8076_Query>(query: Q) throws -> (Q.Returned, sr8076_Filter?)
273+
public protocol ProtoQueryHandler {
274+
func forceHandle_1<Q: Query>(query: Q) -> Void
275+
func forceHandle_2<Q: Query>(query: Q) -> (Q.Returned, BigStruct?)
276+
func forceHandle_3<Q: Query>(query: Q) -> (Q.Returned, Filter?)
277+
func forceHandle_4<Q: Query>(query: Q) throws -> (Q.Returned, Filter?)
277278
}
278279

279-
public protocol sr8076_QueryHandler: sr8076_ProtoQueryHandler {
280-
associatedtype Handled: sr8076_Query
280+
public protocol QueryHandler: ProtoQueryHandler {
281+
associatedtype Handled: Query
281282
func handle_1(query: Handled) -> Void
282283
func handle_2(query: Handled) -> (Handled.Returned, BigStruct?)
283-
func handle_3(query: Handled) -> (Handled.Returned, sr8076_Filter?)
284-
func handle_4(query: Handled) throws -> (Handled.Returned, sr8076_Filter?)
284+
func handle_3(query: Handled) -> (Handled.Returned, Filter?)
285+
func handle_4(query: Handled) throws -> (Handled.Returned, Filter?)
285286
}
286287

287288

288-
public extension sr8076_QueryHandler {
289+
public extension QueryHandler {
289290

290-
// CHECK-LABEL: define{{( dllexport)?}}{{( protected)?}} swiftcc void @"$s22big_types_corner_cases19sr8076_QueryHandlerPAAE13forceHandle_15queryyqd___tAA0e1_F0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.sr8076_QueryHandler, i8** {{.*}}.sr8076_Query, %swift.opaque* noalias nocapture swiftself %1)
291+
// CHECK-LABEL: define{{( dllexport)?}}{{( protected)?}} swiftcc void @"$s22big_types_corner_cases12QueryHandlerPAAE13forceHandle_15queryyqd___tAA0E0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.QueryHandler, i8** {{.*}}.Query, %swift.opaque* noalias nocapture swiftself %1)
291292
// CHECK: call swiftcc void {{.*}}(%swift.opaque* noalias nocapture {{.*}}, %swift.refcounted* swiftself {{.*}})
292293
// CHECK: ret void
293-
func forceHandle_1<Q: sr8076_Query>(query: Q) -> Void {
294+
func forceHandle_1<Q: Query>(query: Q) -> Void {
294295
guard let body = handle_1 as? (Q) -> Void else {
295296
fatalError("handler \(self) is expected to handle query \(query)")
296297
}
297298
body(query)
298299
}
299300

300-
// CHECK-LABEL: define{{( dllexport)?}}{{( protected)?}} swiftcc void @"$s22big_types_corner_cases19sr8076_QueryHandlerPAAE13forceHandle_25query8ReturnedQyd___AA9BigStructVSgtqd___tAA0e1_F0Rd__lF"(%T22big_types_corner_cases9BigStructVSg* noalias nocapture sret({{.*}}) %0, %swift.opaque* noalias nocapture %1, %swift.opaque* noalias nocapture %2, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.sr8076_QueryHandler, i8** {{.*}}.sr8076_Query, %swift.opaque* noalias nocapture swiftself %3)
301+
// CHECK-LABEL: define{{( dllexport)?}}{{( protected)?}} swiftcc void @"$s22big_types_corner_cases12QueryHandlerPAAE13forceHandle_25query8ReturnedQyd___AA9BigStructVSgtqd___tAA0E0Rd__lF"(%T22big_types_corner_cases9BigStructVSg* noalias nocapture sret({{.*}}) %0, %swift.opaque* noalias nocapture %1, %swift.opaque* noalias nocapture %2, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.QueryHandler, i8** {{.*}}.Query, %swift.opaque* noalias nocapture swiftself %3)
301302
// CHECK: [[ALLOC:%.*]] = alloca %T22big_types_corner_cases9BigStructVSg
302303
// CHECK: call swiftcc void {{.*}}(%T22big_types_corner_cases9BigStructVSg* noalias nocapture sret({{.*}}) [[ALLOC]], %swift.opaque* noalias nocapture {{.*}}, %swift.opaque* noalias nocapture {{.*}}, %swift.refcounted* swiftself {{.*}})
303304
// CHECK: ret void
304-
func forceHandle_2<Q: sr8076_Query>(query: Q) -> (Q.Returned, BigStruct?) {
305+
func forceHandle_2<Q: Query>(query: Q) -> (Q.Returned, BigStruct?) {
305306
guard let body = handle_2 as? (Q) -> (Q.Returned, BigStruct?) else {
306307
fatalError("handler \(self) is expected to handle query \(query)")
307308
}
308309
return body(query)
309310
}
310311

311-
// CHECK-LABEL-64: define{{( dllexport)?}}{{( protected)?}} swiftcc { i64, i64 } @"$s22big_types_corner_cases19sr8076_QueryHandlerPAAE13forceHandle_35query8ReturnedQyd___SbAA9BigStructVcSgtqd___tAA0e1_F0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.sr8076_QueryHandler, i8** {{.*}}.sr8076_Query, %swift.opaque* noalias nocapture swiftself %2)
312+
// CHECK-LABEL-64: define{{( dllexport)?}}{{( protected)?}} swiftcc { i64, i64 } @"$s22big_types_corner_cases12QueryHandlerPAAE13forceHandle_35query8ReturnedQyd___SbAA9BigStructVcSgtqd___tAA0E0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.QueryHandler, i8** {{.*}}.Query, %swift.opaque* noalias nocapture swiftself %2)
312313
// CHECK-64: {{.*}} = call swiftcc { i64, i64 } {{.*}}(%swift.opaque* noalias nocapture {{.*}}, %swift.opaque* noalias nocapture {{.*}}, %swift.refcounted* swiftself {{.*}})
313314
// CHECK-64: ret { i64, i64 }
314315

315-
// CHECK-LABEL-32: define{{( dllexport)?}}{{( protected)?}} swiftcc { i32, i32} @"$s22big_types_corner_cases19sr8076_QueryHandlerPAAE13forceHandle_35query8ReturnedQyd___SbAA9BigStructVcSgtqd___tAA0e1_F0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.sr8076_QueryHandler, i8** {{.*}}.sr8076_Query, %swift.opaque* noalias nocapture swiftself %2)
316+
// CHECK-LABEL-32: define{{( dllexport)?}}{{( protected)?}} swiftcc { i32, i32} @"$s22big_types_corner_cases12QueryHandlerPAAE13forceHandle_35query8ReturnedQyd___SbAA9BigStructVcSgtqd___tAA0E0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.QueryHandler, i8** {{.*}}.Query, %swift.opaque* noalias nocapture swiftself %2)
316317
// CHECK-32: {{.*}} = call swiftcc { i32, i32 } {{.*}}(%swift.opaque* noalias nocapture {{.*}}, %swift.opaque* noalias nocapture {{.*}}, %swift.refcounted* swiftself {{.*}})
317318
// CHECK-32: ret { i32, i32 }
318-
func forceHandle_3<Q: sr8076_Query>(query: Q) -> (Q.Returned, sr8076_Filter?) {
319-
guard let body = handle_3 as? (Q) -> (Q.Returned, sr8076_Filter?) else {
319+
func forceHandle_3<Q: Query>(query: Q) -> (Q.Returned, Filter?) {
320+
guard let body = handle_3 as? (Q) -> (Q.Returned, Filter?) else {
320321
fatalError("handler \(self) is expected to handle query \(query)")
321322
}
322323
return body(query)
323324
}
324325

325-
// CHECK-LABEL-64: define{{( dllexport)?}}{{( protected)?}} swiftcc { i64, i64 } @"$s22big_types_corner_cases19sr8076_QueryHandlerPAAE13forceHandle_45query8ReturnedQyd___SbAA9BigStructVcSgtqd___tKAA0e1_F0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.sr8076_QueryHandler, i8** {{.*}}.sr8076_Query, %swift.opaque* noalias nocapture swiftself %2, %swift.error** swifterror %3)
326+
// CHECK-LABEL-64: define{{( dllexport)?}}{{( protected)?}} swiftcc { i64, i64 } @"$s22big_types_corner_cases12QueryHandlerPAAE13forceHandle_45query8ReturnedQyd___SbAA9BigStructVcSgtqd___tKAA0E0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.QueryHandler, i8** {{.*}}.Query, %swift.opaque* noalias nocapture swiftself %2, %swift.error** swifterror %3)
326327
// CHECK-64: {{.*}} = call swiftcc { i64, i64 } {{.*}}(%swift.opaque* noalias nocapture {{.*}}, %swift.opaque* noalias nocapture {{.*}}, %swift.refcounted* swiftself {{.*}}, %swift.error** noalias nocapture swifterror {{.*}})
327328
// CHECK-64: ret { i64, i64 }
328329

329-
// CHECK-LABEL-32: define{{( dllexport)?}}{{( protected)?}} swiftcc { i32, i32} @"$s22big_types_corner_cases19sr8076_QueryHandlerPAAE13forceHandle_45query8ReturnedQyd___SbAA9BigStructVcSgtqd___tKAA0e1_F0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.sr8076_QueryHandler, i8** {{.*}}.sr8076_Query, %swift.opaque* noalias nocapture swiftself %2, %swift.error** swifterror %3)
330+
// CHECK-LABEL-32: define{{( dllexport)?}}{{( protected)?}} swiftcc { i32, i32} @"$s22big_types_corner_cases12QueryHandlerPAAE13forceHandle_45query8ReturnedQyd___SbAA9BigStructVcSgtqd___tKAA0E0Rd__lF"(%swift.opaque* noalias nocapture %0, %swift.opaque* noalias nocapture %1, %swift.type*{{.*}}, %swift.type*{{.*}}, i8** {{.*}}.QueryHandler, i8** {{.*}}.Query, %swift.opaque* noalias nocapture swiftself %2, %swift.error** swifterror %3)
330331
// CHECK-32: {{.*}} = call swiftcc { i32, i32 } {{.*}}(%swift.opaque* noalias nocapture {{.*}}, %swift.opaque* noalias nocapture {{.*}}, %swift.refcounted* swiftself {{.*}}, %swift.error** noalias nocapture {{.*}})
331332
// CHECK-32: ret { i32, i32 }
332-
func forceHandle_4<Q: sr8076_Query>(query: Q) throws -> (Q.Returned, sr8076_Filter?) {
333-
guard let body = handle_4 as? (Q) throws -> (Q.Returned, sr8076_Filter?) else {
333+
func forceHandle_4<Q: Query>(query: Q) throws -> (Q.Returned, Filter?) {
334+
guard let body = handle_4 as? (Q) throws -> (Q.Returned, Filter?) else {
334335
fatalError("handler \(self) is expected to handle query \(query)")
335336
}
336337
return try body(query)

‎test/IRGen/conformance_access_path.swift‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22
// RUN: %FileCheck %s < %t.ll
33

44

5-
// SR-6200: canonicalizing a conformance access path that was built
6-
// without the requirement signature.
5+
// https://github.com/apple/swift/issues/48752
6+
// Canonicalizing a conformance access path that was built without the
7+
// requirement signature.
8+
79
public struct Valid<V> {}
810

911
extension Valid where V: ValidationSuite {}

‎test/IRGen/debug_scope.sil‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ sil_stage canonical
44
import Builtin
55
import Swift
66

7-
// SR-14856: IRGen couldn't handle `SILLocation` with `FilenameAndLocationKind`
8-
// storage kind.
7+
// https://github.com/apple/swift/issues/57203
8+
// IRGen couldn't handle 'SILLocation' with 'FilenameAndLocationKind'.
99

1010
sil_scope 2 { loc "the_file.swift":2:6 parent @foo : $@convention(thin) () -> () }
1111
sil_scope 3 { loc "the_file.swift":3:5 parent 2 }

‎test/IRGen/empty_array.sil‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
// REQUIRES: CODEGENERATOR=X86
99
// REQUIRES: CODEGENERATOR=ARM
1010

11-
// FIXME: SR-3602 test is failing after being unintentionally disabled for a while
11+
// FIXME: https://github.com/apple/swift/issues/46187 test is failing after
12+
// being unintentionally disabled for a while.
1213
// REQUIRES: SR3602
1314

1415
sil_stage canonical

‎test/IRGen/extension_type_metadata_linking.swift‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ extension NSNumber {
4949
public struct Struct {}
5050
}
5151

52-
// SR-9397: not emitting metadata for NSComparisonResult
52+
// https://github.com/apple/swift/issues/51863
53+
// Not emitting metadata for 'NSComparisonResult'
54+
5355
protocol CommandTypes {
5456
associatedtype Result
5557
associatedtype Message

‎test/IRGen/lowered_optional_self_metadata.sil‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ public protocol Protocol {
88
static func foo(_: Self?)
99
}
1010

11-
// SR-3021: Ensure we pass the Self type metadata for Optional methods using the
12-
// formal Optional type and not a lowered SIL type.
11+
// https://github.com/apple/swift/issues/45611
12+
// Ensure we pass the 'Self' type metadata for 'Optional' methods using the
13+
// formal 'Optional' type and not a lowered SIL type.
1314

1415
// CHECK-LABEL: @_TMaGSqFT_T__
1516

@@ -23,7 +24,8 @@ entry(%x : $*Optional<@callee_guaranteed @substituted <T> () -> @out T for <()>>
2324
return undef : $()
2425
}
2526

26-
// SR-3548: Ensure we correctly emit "metadata for layout" for lowered Optional types.
27+
// https://github.com/apple/swift/issues/46136
28+
// Ensure we correctly emit metadata for layout for lowered 'Optional' types.
2729

2830
sil @alloc_stack_optional_with_generic : $@convention(thin) <T> () -> () {
2931
%a = alloc_stack $*Optional<(T, @convention(thin) () -> ())>

‎test/IRGen/objc_class_empty_fields.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// RUN: %target-swift-frontend -primary-file %s -enable-objc-interop -emit-ir | %FileCheck %s --check-prefix=CHECK-%target-ptrsize
22

3-
// SR-1055
3+
// https://github.com/apple/swift/issues/43667
44

55
// CHECK-64: @_DATA__TtC23objc_class_empty_fields14OneEnumWrapper = internal constant { {{.*}}* } { i32 {{[0-9]+}}, i32 16, i32 24
66
// CHECK-32: @_DATA__TtC23objc_class_empty_fields14OneEnumWrapper = internal constant { {{.*}}* } { i32 {{[0-9]+}}, i32 8, i32 12

‎test/IRGen/objc_protocols.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ func gallop<T : Vanner>(_ t: Stirrup<T>) {
212212
canter(t)
213213
}
214214

215-
// SR-7130
215+
// https://github.com/apple/swift/issues/49678
216216
func triggerDoubleInheritedFunging() -> AnyObject {
217217
return NSDoubleInheritedFunging.self as AnyObject
218218
}

0 commit comments

Comments
 (0)