[SR-11619] Spurious error "anonymous closure argument not contained in a closure" in #if false

[DougGregor]

Previous ID	SR-11619
Radar	None
Original Reporter	@DougGregor
Type	Bug

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, StarterBug
Assignee	None
Priority	Medium

md5: fce0a8071c3d74595e44fbbd42aa3fa0

Issue Description:

This code currently produces an error, but shouldn't:

#if false
if $0 { } // error: anonymous closure argument not contained in a closure
#endif

[belkadan]

I'm not sure it shouldn't. Code in false branches of ifs still has to parse unless the guard is #if swift or #if compiler. It's fuzzy whether this is a parse error or a semantic error, though.

[swift-ci]

Comment by Tapan Thaker (JIRA)

Just checked, this is a parse error. Happens at ParseExpr.cpp#L2863.
So does this mean we good to close this issue?

[DougGregor]

I consider this a bug, because I think the error should come from semantic analysis, not from the parser.