Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that position is within buffer bounds in BridgedSourceLoc.init #68610

Closed
AnthonyLatsis opened this issue Sep 19, 2023 · 4 comments · Fixed by #68643
Closed

Assert that position is within buffer bounds in BridgedSourceLoc.init #68610

AnthonyLatsis opened this issue Sep 19, 2023 · 4 comments · Fixed by #68643
Labels
ASTGen Area → compiler: The ASTGen module, which translates SwiftSyntax trees to the C++ AST compiler The Swift compiler itself good first issue Good for newcomers task

Comments

@AnthonyLatsis
Copy link
Collaborator

Currently, we construct a null location if the input position is out of bounds, meaning the position is invalid or the buffer is null/wrong. Neither is ever expected to happen in ASTGen, and if it does, we don’t want it to go unnoticed or cause a less informative failure downstream.
@AnthonyLatsis AnthonyLatsis added compiler The Swift compiler itself task ASTGen Area → compiler: The ASTGen module, which translates SwiftSyntax trees to the C++ AST good first issue Good for newcomers labels Sep 19, 2023
@saehejkang
Copy link
Contributor

I would like to pick up this issue please 👍🏽

@saehejkang saehejkang mentioned this issue Sep 19, 2023
Merged
@saehejkang
Copy link
Contributor

this issue can now be closed @AnthonyLatsis

@saehejkang
Copy link
Contributor

@AnthonyLatsis I did not know how else to reach out to you. Do you have any recommendations for good first issues that are up to date and not super old? Or are there any regular issues that are good for me to work on?

@AnthonyLatsis
Copy link
Collaborator Author

@saehejkang Looks like you beat me to it. #68212 is a good find.

@AnthonyLatsis AnthonyLatsis mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ASTGen Area → compiler: The ASTGen module, which translates SwiftSyntax trees to the C++ AST compiler The Swift compiler itself good first issue Good for newcomers task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ASTGen]: Assert that the position is within buffer bounds for BridgedSourceLoc saehejkang/swift
2 participants
@AnthonyLatsis @saehejkang