Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxx-interop] Fix assert failure exporting C++ types to Obj-C #78219

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Xazax-hun
Copy link
Contributor

This is not supported, of course. But now, instead of an assertion failure we properly mark the declaration as unavailable.

Fixes #78190.

rdar://141492654

@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Dec 16, 2024
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is not supported, of course. But now, instead of an assertion
failure we properly mark the declaration as unavailable.

Fixes #78190.

rdar://141492654
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

@Xazax-hun Xazax-hun enabled auto-merge December 16, 2024 21:08
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test windows

@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test linux

1 similar comment
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test linux

@Xazax-hun Xazax-hun merged commit 1bdefa1 into main Dec 18, 2024
3 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/cxx-to-objc branch December 18, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure when emitting Obj-C header for function that uses C++ type
2 participants