Skip to content

Use workspace/tests and document/tests requests to list tests inside a project #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahoppen opened this issue Feb 21, 2024 · 8 comments
Closed
Assignees
Labels

Comments

@ahoppen
Copy link
Member

ahoppen commented Feb 21, 2024

swiftlang/sourcekit-lsp#611 introduced the workspace/tests and document/tests methods to lists all tests within a workspace or document. The VS Code extension should be using them to list the available tests.

@adam-fowler
Copy link
Contributor

Awesome I missed that went in.

@adam-fowler
Copy link
Contributor

Does this request need a built project?

@ahoppen
Copy link
Member Author

ahoppen commented Feb 21, 2024

Yes, it does. It reads the index to find the tests

@adam-fowler
Copy link
Contributor

adam-fowler commented Feb 27, 2024

@ahoppen Do these return SymbolInformation always, or can they return DocumentSymbols?

@ahoppen
Copy link
Member Author

ahoppen commented Feb 27, 2024

It currently always returns SymbolInformation and I don’t see any reason for us to change that in the foreseeable future.

@adam-fowler
Copy link
Contributor

Ok that's cool. The client always has the option of both.

By the way I have something up and running. I'll be posting a PR in the next day or so.

@plemarquand
Copy link
Contributor

I'm in the process of looking at these and integrating them in to the Test Explorer.

@adam-fowler
Copy link
Contributor

@plemarquand Please review #761 and #762 for more details about both requests. It was easier to break them out into separate issues. I going to close this in favour of the two new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants