Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

Custom comparator is not working #302

Open
mdsahib opened this issue May 10, 2018 · 0 comments
Open

Custom comparator is not working #302

mdsahib opened this issue May 10, 2018 · 0 comments

Comments

@mdsahib
Copy link

mdsahib commented May 10, 2018

I am trying to pass a custom comparator for a column but it is not getting called.

After researching the source code, I found that the comparator function is not passed while sorting the data.

      var clientSorts = [];
      for(var i=0, len=sorts.length; i < len; i++) {
        var c = sorts[i];
        if(c.comparator !== false){
          var dir = c.sort === 'asc' ? '' : '-';
          clientSorts.push(dir + c.prop);
        }
      }

      if(clientSorts.length){
        // todo: more ideal to just resort vs splice and repush
        // but wasn't responding to this change ...
        var sortedValues = this.$filter('orderBy')(this.rows, clientSorts);
        this.rows.splice(0, this.rows.length);
        this.rows.push(...sortedValues);
      }

Above snippet can be found here

I am trying these feature with the following versions:

  1. AngularJS v1.5.11
  2. angular-data-table v0.7.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant