Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tab styles #1655

Closed
2 of 3 tasks
Tracked by #1215
gfellerph opened this issue Jul 24, 2023 · 3 comments
Closed
2 of 3 tasks
Tracked by #1215

Update tab styles #1655

gfellerph opened this issue Jul 24, 2023 · 3 comments
Labels
💔 BREAKING This is a breaking change and results in a new major version 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 📦 styles Related to the @swisspost/design-system-styles package
Milestone
Breaking changes

Comments

@gfellerph
Copy link
Member

gfellerph commented Jul 24, 2023 •
edited
Loading

The tabs component got a design overhaul.

Design: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=70-18&mode=design&t=gh5btDmzaOgNux8c-0

Optimization Ticket: #1125

Scope: These styles should only be applied to the tabs web component. The ngb-tabs should stay as they are to ensure backwards compatibility.

Tasks
Beta Give feedback
  3. Overflowing tab headers are navigable by arrows #1938
@gfellerph gfellerph added the 💭 draft Issue is not ready for development label Jul 24, 2023
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package and removed 💭 draft Issue is not ready for development labels Aug 8, 2023
@gfellerph gfellerph mentioned this issue Aug 8, 2023
Closed
@gfellerph gfellerph added 💭 draft Issue is not ready for development on hold Wait for something to be done, before continue working on this Issue and removed 💭 draft Issue is not ready for development labels Aug 9, 2023
@github-actions github-actions bot added stale and removed stale labels Feb 14, 2024
@github-actions github-actions bot added the stale label May 15, 2024
@gfellerph gfellerph removed on hold Wait for something to be done, before continue working on this Issue stale labels Jul 3, 2024
@gfellerph
Copy link
Member Author

Check if color variation code is removed. If yes, ticket is already done.

@gfellerph gfellerph self-assigned this Jul 3, 2024
@gfellerph gfellerph added the 💔 BREAKING This is a breaking change and results in a new major version label Jul 15, 2024
@gfellerph gfellerph mentioned this issue Jul 15, 2024
Open
@gfellerph gfellerph added this to the Breaking changes milestone Jul 15, 2024
@gfellerph
Copy link
Member Author

Tab color variant styles are still present https://github.com/swisspost/design-system/blob/main/packages/styles/src/components/tabs/_tab-title.scss#L115. They can be removed.

@gfellerph gfellerph removed their assignment Jul 24, 2024
@gfellerph gfellerph added the 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem label Aug 8, 2024
@gfellerph
Copy link
Member Author

Closing in favor of a future tab v2 ticket. Breaking changes are no longer being implemented for v1 components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💔 BREAKING This is a breaking change and results in a new major version 🦌 fair game This issue can potentially be closed because it no longer fits into the ecosystem 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Breaking changes
Development

No branches or pull requests
1 participant
@gfellerph