Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the heading level property required #3091

Closed
1 task
Tracked by #2576
, #1215
...
alizedebray opened this issue May 17, 2024 · 0 comments · Fixed by #3383
Closed
1 task
Tracked by #2576
, #1215
...

Make the heading level property required #3091

alizedebray opened this issue May 17, 2024 · 0 comments · Fixed by #3383
Assignees
@schaertim
Labels
💔 BREAKING This is a breaking change and results in a new major version 📦 components Related to the @swisspost/design-system-components package
Milestone
Breaking changes

Comments

@alizedebray
Copy link
Contributor

alizedebray commented May 17, 2024 •
edited by gfellerph
Loading

The heading-level should be required on the post-accordion to ensure good HTML structure.

Also the heading-level on post-accordion-item is currently deprecated and should be removed from the documentation.

Tasks
Beta Give feedback
@alizedebray alizedebray mentioned this issue May 17, 2024
Closed
@alizedebray alizedebray added 📦 components Related to the @swisspost/design-system-components package 💔 BREAKING This is a breaking change and results in a new major version labels May 17, 2024
@alizedebray alizedebray mentioned this issue May 17, 2024
Open
@gfellerph gfellerph added this to the Next milestone May 29, 2024
@gfellerph gfellerph modified the milestones: Next, Breaking changes Jul 15, 2024
@schaertim schaertim linked a pull request Aug 8, 2024 that will close this issue
chore(docs,components): make heading-level required and update docs #3383
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaertim schaertim

Labels
💔 BREAKING This is a breaking change and results in a new major version 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Archived in project
Milestone
Breaking changes
Development

Successfully merging a pull request may close this issue.

chore(docs,components): make heading-level required and update docs swisspost/design-system
3 participants
@gfellerph @alizedebray @schaertim