Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextjs package: build error because of a post-accordion element without the required heading-level property #3563

Open
oliverschuerch opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@oliverschuerch
Copy link
Contributor

Describe the bug
The post-accordion web-component now defines its headingLevel property as required!
Therefore we get a error in the nextjs package (only used for testing at the moment), because in the page.tsx file such a component is used, but without this attribute.

To Reproduce

  1. checkout the main branch
  2. run ``pnpm bootstrap`

Expected behavior
To have no error when building the nextjs package

Screenshots
If applicable, add screenshots to help explain your problem.

@oliverschuerch oliverschuerch added this to the Design v2 milestone Sep 19, 2024
@oliverschuerch oliverschuerch changed the title [bug]: nextjs package: build error because of a post-accordion element without the required heading-level property Sep 19, 2024
@oliverschuerch
Copy link
Contributor Author

@alizedebray I hope it is ok that I assigned you to this task directly.
I think most of our PRs are red, because of this and as soon as it is fixed a lot of them should become green again.
If you need someone to approve the PR tomorrow, just login with the oss@post.ch user in a different browser ;)
But don't say that to Philipp 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 💻 Ready for development
Development

No branches or pull requests

2 participants