Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input elements V2]: To provide placeholder option or not? #4308

Open
sandra-post opened this issue Dec 16, 2024 · 1 comment
Open

[input elements V2]: To provide placeholder option or not? #4308

sandra-post opened this issue Dec 16, 2024 · 1 comment
Assignees
Labels
needs: 📃 docs update Something has changed in the design or implementation which needs to be documented accordingly
Milestone

Comments

@sandra-post
Copy link

Situation

  • In Figma, we did not include the placeholder to input elements (text input, text area, ...) due to possible accessibility issues (see research)
  • In Storybook, the following elements currently have a placeholder:

Accessibility issues

From accessibility POV, there are some issues when using placeholders:

  • if used as replacement for accurate labels and/or hint texts --> not accessible because placeholder disappears on focus
  • its ok to use them but only additionally to labels/hints, so that on focus, the information given with the placeholder is still visible via label and/or hint
  • Theoretically, floating labels serve as placeholders

Question

Do we provide with Design System V2 placeholders for input elemnts or not?
--> If YES: Adjust design in Figma
--> If NO: Remove from Storybook

@sandra-post sandra-post added the needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. label Dec 16, 2024
@sandra-post sandra-post self-assigned this Dec 16, 2024
@sandra-post
Copy link
Author

sandra-post commented Dec 17, 2024

Decision Pattern Discussion 17-Dec-2024

  • We dont add Placeholder in design
  • We add recommendation to not use it in design and code documentation
  • We do NOT block placeholder by code, so if devs still want to use it, we are not blocking them. But we are also not promoting it

Tasks

  • Add recommendation in design docs
  • Add recommendation in dev docs
  • Remove placeholder in implementation (compos: Text input, Search input, Text area)

@gfellerph gfellerph removed the needs: 💬 pattern discussion This issue will be discussed in the next Pattern Discussion meeting. label Dec 17, 2024
@sandra-post sandra-post added the needs: 📃 docs update Something has changed in the design or implementation which needs to be documented accordingly label Dec 17, 2024
@sandra-post sandra-post moved this from 👀 Triage to 🎨 Ready for design docs in Design System Production Board Dec 17, 2024
@sandra-post sandra-post added this to the Design v2 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: 📃 docs update Something has changed in the design or implementation which needs to be documented accordingly
Projects
Status: 🎨 Ready for design docs
Development

No branches or pull requests

2 participants