New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove properies "expireAfter" and "queueExpireAfter" from Hooks #203

Open

oli-h opened this issue Feb 20, 2018 · 0 comments

Labels

Contributor

oli-h commented Feb 20, 2018 •

edited

Loading

"expireAfter" has some hard to understand side effects:

if it's not set in the Hook, then it is implicit assumed as "30 seconds"
it applies only if no "x-expire-after" is present yet.

Consequences:

This magic "30 seconds" expiry is a often unwanted side effect, i.e. requests in queue timeout to early
we cannot change (i.e. override) an "x-expire-after" header with this
we cannot have entries in the queue without "x-expire-after" (need to set x-expire-after to -1 instead)

We now can do this all with the new dynamic headers feature (#43 ), i.e:

set x-expire-after unconditionally
override if one already exists (i.e. increase or reduce expiry)
set an x-expire-after only if none present
and please: no magic "30 seconds" any more

Same arguments apply to "queueExpireAfter"

mcweba added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment