Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid header duplication "x-rp-unique_id" and "x-rp-unique-id" #217

Open
oli-h opened this issue Apr 27, 2018 · 1 comment
Open

Avoid header duplication "x-rp-unique_id" and "x-rp-unique-id" #217

oli-h opened this issue Apr 27, 2018 · 1 comment

Comments

@oli-h
Copy link
Contributor

oli-h commented Apr 27, 2018

Note the dash vs. the underscore in the header name.
The one with the underscore probably is a typo - but still both header names occur in various Gateleen source files - often with a fall-back implementation like here:
https://github.com/swisspush/gateleen/blob/v1.1.27/gateleen-routing/src/main/java/org/swisspush/gateleen/routing/StorageForwarder.java#L148-L151

Additionally, we have an header x-request-id which seems to have the same or very similar semantic.
There should be at least a proper documentation for both (or all three, if the underscore-version is intentional (and not a typo)

@mcweba
Copy link
Collaborator

mcweba commented Feb 1, 2023

I already started this task with the following Pull Request: #495.
We want to get rid of the x-rp-unique-id header and only use x-rp-unique_id and x-request-id. For the x-request-id header we should set this when no x-rp-unique-id is present in the request. Right now, x-request-id is only read, but newer written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants