Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only merge own properties #9

Open
greim opened this issue Aug 22, 2014 · 1 comment
Open

Only merge own properties #9

greim opened this issue Aug 22, 2014 · 1 comment

Comments

@greim
Copy link

greim commented Aug 22, 2014

The for ... in loop in this module should only copy a property if item.hasOwnProperty(key), otherwise it will copy prototype properties, resulting in unexpected and hard-to-find bugs.
@greim greim mentioned this issue Aug 22, 2014
Closed
@stebunovd stebunovd mentioned this issue Mar 17, 2015
Open
@stebunovd
Copy link

Stumbled upon one of those hard-to-find bugs - iterating over unwanted properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greim @stebunovd