Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-crc to v2 #126

Closed
rafaelmaeuer opened this issue Jun 30, 2021 · 4 comments · Fixed by #284
Closed

Update node-crc to v2 #126

rafaelmaeuer opened this issue Jun 30, 2021 · 4 comments · Fixed by #284
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@rafaelmaeuer
Copy link
Contributor

Currently updating node-crc to a version > 2.0.0 fails: magiclen/node-crc#8
@rafaelmaeuer rafaelmaeuer added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 30, 2021
@rafaelmaeuer rafaelmaeuer self-assigned this Jun 30, 2021
@rafaelmaeuer rafaelmaeuer changed the title Update node-crc when build error is fixed Update node-crc to v2 when build error is fixed Jun 30, 2021
@rafaelmaeuer
Copy link
Contributor Author

rafaelmaeuer commented Jul 7, 2021 •
edited
Loading

"You need to set up the development environment for Rust to compile the binary.

You can simply install rustup with this command: curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh. By default, it would also install the stable Rust compiler and the cargo command tool, which should be enough to build/install this project."

@rafaelmaeuer
Copy link
Contributor Author

So if I understand this, upgrading node-crc to v2 requires the installation of rustup during docker build...?

@rafaelmaeuer
Copy link
Contributor Author

As mentioned in magiclen/node-crc#9 integration of prebuild binaries is required to avoid rust-tooling in docker

@rafaelmaeuer rafaelmaeuer changed the title Update node-crc to v2 when build error is fixed Update node-crc to v2 Jul 27, 2021
@rafaelmaeuer rafaelmaeuer mentioned this issue Jul 27, 2021
Merged
@rafaelmaeuer rafaelmaeuer linked a pull request Mar 21, 2022 that will close this issue
Dev/update node crc #284
Merged
@rafaelmaeuer
Copy link
Contributor Author

Finally able to fix this with help of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev/update node crc swrlab/ard-eventhub
2 participants
@frytg @rafaelmaeuer