Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of timezones #38

Open
sxppro opened this issue Oct 27, 2024 · 3 comments · Fixed by #39
Open

Improve handling of timezones #38

sxppro opened this issue Oct 27, 2024 · 3 comments · Fixed by #39
Labels
enhancement Minor feature or request

Comments

@sxppro
Copy link
Owner

sxppro commented Oct 27, 2024

Using https://github.com/date-fns/tz

@sxppro sxppro linked a pull request Oct 28, 2024 that will close this issue
5 tasks
@sxppro
Copy link
Owner Author

sxppro commented Nov 1, 2024

There are still a few components that use new Date(), these may be removed or fixed later

@sxppro sxppro added the enhancement Minor feature or request label Nov 9, 2024
@sxppro
Copy link
Owner Author

sxppro commented Nov 18, 2024

I think this is mostly done, although will have to do some more checks to ensure everything is cleaned up and converted to use TZDate or if methods have to work with Date, ensure they respect the timezone using { in: tz(TZ) } or some other way

@sxppro
Copy link
Owner Author

sxppro commented Dec 11, 2024

Aggregation pipelines that utilise $densify, e.g. monthly spending over time, are all hardcoded to group using UTC time, so they will consider UTC months only. $densify struggles with daylight-saving, adding in additional items to the result, see: https://www.mongodb.com/community/forums/t/bug-densify-and-daylight-saving/206378/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Minor feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant