Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter key keymaps with shift modifier of form <C-X>, <C-S-X> do not work #1441

Closed
smackesey opened this issue Aug 8, 2024 · 3 comments · Fixed by #1448
Closed

Letter key keymaps with shift modifier of form <C-X>, <C-S-X> do not work #1441

smackesey opened this issue Aug 8, 2024 · 3 comments · Fixed by #1448
Labels
enhancement New feature or request

Comments

@smackesey
Copy link

What system are you running Yazi on?

macOS

What terminal are you running Yazi in?

kitty 0.35.2

yazi --debug output

Yazi
    Version: 0.3.0 (Homebrew 2024-08-01)
    Debug  : false
    OS     : macos-aarch64 (unix)

Ya
    Version: 0.3.0

Emulator
    Emulator.via_env: ("xterm-kitty", "")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kitty

Desktop
    XDG_SESSION_TYPE: None
    WAYLAND_DISPLAY : None
    DISPLAY         : None

SSH
    shared.in_ssh_connection: false

WSL
    /proc/sys/fs/binfmt_misc/WSLInterop: false

Variables
    SHELL              : Some("/bin/zsh")
    EDITOR             : Some("nvim -u /Users/smackesey/stm/conf/ext/vim/init/env/terminal.lua")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None
    ZELLIJ_SESSION_NAME: None

Text Opener
    default: Some(Opener { run: "${EDITOR:=vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:=vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

tmux
    TMUX   : false
    Version: 3.4

Dependencies
    file             : 5.41
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-36
    fzf              : 0.54.3
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : No such file or directory (os error 2)
    zoxide           : 0.9.4
    7z               : No such file or directory (os error 2)
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1

Did you try the latest nightly build to see if the problem got fixed?

No, and I'll explain why below

Describe the bug

I am trying to map multi-modifier combinations of letter keys with the shift modifier. This form works:

{ on = "<C-S-X>", run = "shell 'echo \\<C-S-X\\>' --interactive" }

But these two forms do not:

{ on = "<C-S-k>", run = "shell 'echo \\<C-S-k\\>' --interactive" },
{ on = "<C-K>", run = "shell 'echo \\<C-K\\>' --interactive" },

Seems like both of the above should work, as is you effectively have to redundantly specify shift with both S- and the capitalized form of the letter.

Minimal reproducer

Observe that these do not work:

# keymap.toml
[manager]

prepend_keymap = [
  { on = "<C-S-k>", run = "shell 'echo \\<C-S-k\\>' --interactive" },
  { on = "<C-K>", run = "shell 'echo \\<C-K\\>' --interactive" },
]

Anything else?

No response

@smackesey smackesey added the bug Something isn't working label Aug 8, 2024
@sxyazi sxyazi added enhancement New feature or request and removed bug Something isn't working labels Aug 9, 2024
@sxyazi
Copy link
Owner

sxyazi commented Aug 9, 2024

Please try #1448

@smackesey
Copy link
Author

Confirmed working on HEAD-- thanks for the quick fix!

Copy link

github-actions bot commented Sep 9, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants