Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight decay only applied when printing averaged stats #132

Open
EinarSommerfeldt opened this issue Oct 27, 2023 · 0 comments
Open

Weight decay only applied when printing averaged stats #132

EinarSommerfeldt opened this issue Oct 27, 2023 · 0 comments

Comments

@EinarSommerfeldt
Copy link

Hi, I'm looking through opt.py and noticed that the code
if args.weight_decay_sh < 1.0: grid.sh_data.data *= args.weight_decay_sigma if args.weight_decay_sigma < 1.0: grid.density_data.data *= args.weight_decay_sh
Only runs inside
if (iter_id + 1) % args.print_every == 0:
Is it intentional to only update weight decay when printing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant