-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumbs v2: add hierarchy, title, and other options. #668
Comments
Users also requested a custom breadcrumb name field for posts and terms. |
"Should we affect only the structured data JSON or the shortcode?" I'd vote for having them affected both simultaneously; not independently tweakable. The breadcrumb hierarchy generation is cached. So, once it's done generating for the structured data, we can reuse that for the breadcrumb shortcode. Repeated use of the shortcode would only regenerate the HTML, not the hierarchy, thus avoiding all expensive (database) requests. The breadcrumb generation is one of the most expensive things TSF does regarding performance. Doubling its impact isn't welcome. |
It's nice to hear you implement this feature. Do you plan to publish this feature anytime soon? |
I'm still collecting data and planning this feature, and I have other features to attend to, so please do not hold your breath just yet. |
Another user used the breadcrumb shortcode under the title, which wasn't pretty. Removing the current page's breadcrumb fixed that. Still, we shouldn't remove the current page crumb from the Schema.org output. This must be sieved out during the shortcode generation. The user also benefited from adding |
My best practice when layout and css is set all element padding, margin to 0. I must css for tsf-breadcrumb
|
Hi, I have a custom css for tsf-breadcrumb
|
Hi @sybrew ,
|
A user also requested to remove the current post from the breadcrumb. To do this visually, please use this CSS: .tsf-breadcrumb .breadcrumb-item:last-child {
display: none;
}
.tsf-breadcrumb .breadcrumb-item:nth-last-child(2):after {
display: none;
} Alternatively, you can use this filter in PHP to account for custom classes: add_filter(
'the_seo_framework_breadcrumb_shortcode_css',
function ( $css, $class ) {
$css["nav.$class li:last-child"][] = 'display:none';
$css["nav.$class li:nth-last-child(2):after"][] = 'display:none';
return $css;
},
10,
2,
); |
Any news on this planned update? Fantastic plugin by the way. Just the breadcrumb structure pulling the meta title is stopping our design studio using it across the board. Hope it can be implemented soon. Keep up the great work. |
Thanks :) This rework of breadcrumbs is planned for TSF v5.2. In any case, we should probably replace the |
I’ll continue to use the other tools on the market for the time being but I’ll be keeping a close eye on this as I’ll happily make the switch when that has been implemented. I do love the bare bones feel and speed of your plugin. |
Another user suggested (via email): Set a max crumb length and replace or hide parent crumbs.
We should not permit trimming fewer than 3 crumbs, even though some might find that aesthetically better; it would indicate that WordPress's Post Type and Taxonomy relationships are being used incorrectly. Allowing this to be hidden will not solve that problem. |
From #705:
|
From various requests*1:
Allow the selection of a breadcrumb title type: SEO title or Meta Title.
I'll mark all titles that do not follow a default method with "discrepancy."
Also, allow to select a breadcrumb hierarchy per request type (post type, date, home, etc.):
For example, do not use product categories for a product, but do use categories for a post.
These issues are combined because we'd have to implement a new interface for breadcrumbs specifically.
Yet, most people would be happy when allowed to toggle the breadcrumb title type already. So, splitting this issue into two might still happen.
*1:
The text was updated successfully, but these errors were encountered: