-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support query parameters in routes #130
Comments
I would be willing to take a look at this. |
Go ahead! |
will make a pr |
@lukechu10 can i rewrite the url segment (parsing, matching) code to work more like proc_macros (tokenstreams, syn/parsing, quote/in this case matching) instead of doing weird string splitting that is hard to get right and has many edge cases |
Are you talking about for supporting query parameters? To be honest, I haven’t even really thought about how I would want the API to look. However, I don’t think putting this into the process-macro would be a good idea since in that case you should be using dynamic route paths/segments anyways. I was thinking of something more along the lines of SolidJS useSearchParams: https://docs.solidjs.com/solid-router/reference/primitives/use-search-params what do you think? |
i was starting to work on an implementation that would handle this: #[to("/existing/<param>?query=val&match=<capture>&every=<all..>#<frag>")] but simply getting the query and frag from a function in a component would also be fine i guess, it might not be very ssr friendly but once there are first-party server integrations it should be fine |
No description provided.
The text was updated successfully, but these errors were encountered: