Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Iteration example is incorrect (template <-> view) #314

Closed
AMNRG opened this issue Dec 13, 2021 · 1 comment · Fixed by #317
Closed

Documentation: Iteration example is incorrect (template <-> view) #314

AMNRG opened this issue Dec 13, 2021 · 1 comment · Fixed by #317
Labels
A-docs Area: documentation C-bug Category: bug, something isn't working

Comments

@AMNRG
Copy link
Contributor

AMNRG commented Dec 13, 2021

Describe the bug
In the documentation under the section Iteration the property view is used in the example, which is however still named template in KeyedProps and IndexedProps.
Maybe we should rename the property for consistency.
@AMNRG AMNRG added the C-bug Category: bug, something isn't working label Dec 13, 2021
@lukechu10
Copy link
Member

yeah that's a typo in the docs. If you could send a PR, that would be great. Also just change the next docs, not the 0.7 docs because that would be updated by next release.

@lukechu10 lukechu10 added the A-docs Area: documentation label Dec 13, 2021
@AMNRG AMNRG mentioned this issue Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation C-bug Category: bug, something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix example code in iteration docs
2 participants
@lukechu10 @AMNRG