Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari on OSX #91

Open
razor-1 opened this issue Jun 16, 2015 · 4 comments
Open

Safari on OSX #91

razor-1 opened this issue Jun 16, 2015 · 4 comments

Comments

@razor-1
Copy link

razor-1 commented Jun 16, 2015

I recently started noticing an issue, on Safari 8.0.6 with OSX 10.10.3. The contextmenu pops up and immediately disappears. Upon debugging it looks like another click is being registered just outside the contextmenu itself. If you hold the mouse down and drag the cursor into the menu area it will work normally, but just clicking causes it to disappear right away.

@razor-1
Copy link
Author

razor-1 commented Jul 5, 2015

Changing to use pageX and pageY to calculate position fixes this. So probably some additional logic is needed in show() to work around whatever the Safari issue is. Maybe all the code in show() could just run if position is fixed on the menu, and otherwise keep it simple with pageX and pageY?

@razor-1
Copy link
Author

razor-1 commented Jul 8, 2015

Actually, I think it has to do with control-click to right-click. Safari fires both a contextmenu and a click with ctrlKey set on a control-click. If this project is not abandoned, which it appears it is as no pull requests have been approved in some time, I can provide a simple fix.

@ricaragao
Copy link

Hi @razor-1 , what fix did you do to this issue?

@razor-1
Copy link
Author

razor-1 commented Oct 24, 2016

@ricaragao you can look at commit e161a0c from razor-1/bootstrap-contextmenu to see how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants