Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unify SYG_DOM variables into a single SYG_CHAINS variable #134

Merged
merged 2 commits into from
Mar 16, 2023
Merged

feat: unify SYG_DOM variables into a single SYG_CHAINS variable #134

merged 2 commits into from
Mar 16, 2023

Conversation

mpetrun5
Copy link
Collaborator

unify SYG_DOM variables into a single SYG_CHAINS variable.
Needs updates to the task files and configurations on AWS.

Description

Related Issue Or Context

Closes: #130

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

Go Test coverage is 66.8 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 5e08745 into main Mar 16, 2023
@mpetrun5 mpetrun5 deleted the mpetrun5/merge-syg-domain-variables branch March 16, 2023 12:32
@MakMuftic MakMuftic mentioned this pull request Mar 16, 2023
Merged
mpetrun5 added a commit that referenced this pull request Mar 20, 2023
@mpetrun5
feat: unify SYG_DOM variables into a single SYG_CHAINS variable (#134)
1ae37a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@waymobetta waymobetta Awaiting requested review from waymobetta

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor SYG_DOM_X env variables to be just SYG_DOMAINS
3 participants
@mpetrun5 @MakMuftic @nmlinaric