Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore extra networks from shared config #163

Merged
merged 1 commit into from
May 4, 2023

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented May 4, 2023

Currently, if shared config has extra networks it appends it in its incomplete state.
This PR only allows for networks that are actually configured in the env or file.

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Go Test coverage is 66.1 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 9eaf1c6 into main May 4, 2023
@mpetrun5 mpetrun5 deleted the mpetrun5/ignore-shared-config-extra-networks branch May 4, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants